continue custom node element binding issues pt1#9609
continue custom node element binding issues pt1#9609mjkkirschner merged 5 commits intoDynamoDS:masterfrom
Conversation
add test which fails before change
mjkkirschner
changed the title
|
test files are something like this: where the callsite data has been generated manually, encoded into base64 and added to the file - then the functionScope has been altered to something like |
|
LGTM! |
aparajit-pratap
left a comment
aparajit-pratap
left a comment
There was a problem hiding this comment.
@mjkkirschner do any of the tests you added test the case where (1) there are more than one creation nodes inside the same custom node definition?
| CurrentDynamoModel.TraceReconciliationProcessor = new TestTraceReconciliationProcessor(0); | ||
| Assert.AreEqual(6, ws.Nodes.Count()); | ||
| var dummyNodes = ws.Nodes.OfType<DummyNode>(); | ||
| Assert.AreEqual(0, dummyNodes.Count()); |
There was a problem hiding this comment.
Can't we just use AssertNoDummyNodes function here?
There was a problem hiding this comment.
currently I think that method is only implemented for system tests: this is a model test - do you want me to implement something like that in modelTestBase?
- we also still need to check if the custom node was loaded as when it fails it's not marked as a dummy node.
|
@aparajit-pratap - yes, the custom node definition here has two creation nodes with the same name / function signature inside it. |
|
LGTM! |
aparajit-pratap
added
LGTM
3 participants
Purpose
continues this PR from @aparajit-pratap : #9527
please see his PR for a very good writeup of the issue and explanation of his fix.
I'm doing some testing and adding automated tests. Also considering edge cases that might arise.
Declarations
Check these if you believe they are true
*.resxfilesReviewers
@aparajit-pratap
@scottmitchell
FYIs
@smangarole
@ZiyunShang
@AndyDu1985