DYN-1681a: As a Dynamo user, I want to resize the Set Value dialog#9600
DYN-1681a: As a Dynamo user, I want to resize the Set Value dialog#9600scottmitchell merged 2 commits intoDynamoDS:masterfrom
Conversation
|
Finally ! thanks @scottmitchell ! |
|
LGTM after unit test |
|
@scottmitchell @mjkkirschner Forgot how we conclude to unit test this, do you recall? |
|
@QilongTang Yes, unit test is part of the AC. Working on that now. I was thinking the test should ensure the window cannot become larger than the screen. Anything else we should test here? |
|
Merging this PR and creating a new task to test this functionality with a Selenium test. |
|
@scottmitchell A few points from testing:
Can we please make the minimum values honour the default open values, or something more appropriate than this? This also breaks the graphical icons of Minimize/Expand/Close.
Having 'Set Value...' up here doesn't make sense to a typical Dynamo user. Please rename to 'Write note here'
This is super cool!
|
…9600) * Added resizing for EditWindow * Added MaxHeight and MaxWidth to Edit Window
5 participants
Purpose
This PR addresses the first part of DYN-1681, which is to allow users to resize the Set Value dialog so that they can see more of the text they are editing.
This PR does not replicate Group text editing functionality for Notes.
Declarations
Check these if you believe they are true
*.resxfilesReviewers
FYIs