DYN-1688: Fix regression with replication over list inputs with nested sublists#9559
Conversation
| var dsArray = runtimeCore.Heap.ToHeapObject<DSArray>(array); | ||
| foreach (var sv in dsArray.Values) | ||
| { | ||
| if(IsEmpty(sv, runtimeCore)) continue; |
There was a problem hiding this comment.
We don't want to add a type for an empty list. On the other hand we want to ignore it and inspect the next element of the array.
|
Can we conclude on difference between this one and #9554? Are they both needed? |
I'm not sure about #9554. I'm not convinced it is the right fix. Since the self-serve CI is broken, I ran the language tests locally on this PR and they all pass. I will do more testing on this PR including manual testing. |
|
Added the tests for this. Once we verify on the self serve, we can merge this. I will be closing the other PR (#9554) related to this same issue |
|
Updated performance benchmarking results. |
|
So I interpret this perf benchmark to mean that the results are essentially the same? |
Yep. |
…d sublists (DynamoDS#9559) * fix regression with replication over list inputs with nested sublists * Tests * DS language test * Update the test (cherry picked from commit da39519)
* Cherry-picking #9388 into 2.0.3 * Cherry-picking #9559 into 2.0.3 * Cherry-picking #9578 into 2.0.3 * cherry-picking #9632 into 2.0.3 * cherry-picking #9408 into 2.0.3 * cherry-picking #9441 into 2.0.3 * Adding gradient.png for the Test_PerforationsByImage test. This was missed while cherrypicking #9441 * Removing DSCoreDataTests.cs as this was the test fixture was introduced in a different commit and is not needed here.
4 participants
Purpose
JIRA: https://jira.autodesk.com/browse/DYN-1688
This fixes a regression from 2.0 where a list containing an empty sublist as its first element followed by another list (of the same rank) did not replicate properly over a node.
Performance results before and after the fix for the same long-running test:
Declarations
Check these if you believe they are true
*.resxfilesReviewers
@reddyashish
@mjkkirschner
FYIs
@QilongTang @saintentropy