Exclude stack trace from being included in the new GitHub issues request#9523
Merged
alfarok merged 2 commits intoDynamoDS:masterfrom Feb 27, 2019
Merged
Exclude stack trace from being included in the new GitHub issues request#9523alfarok merged 2 commits intoDynamoDS:masterfrom
alfarok merged 2 commits intoDynamoDS:masterfrom
Conversation
7 tasks
alfarok
changed the title
Contributor
|
How do we determine the issue tile? I may have asked before but forgot how we define that currently |
Member
|
@alfarok do tests need to be updated? |
Contributor
Author
|
@QilongTang The title is set here which attempts to append the current Dynamo version. |
Contributor
|
@alfarok Thanks. If there is no unit tests to be updated like @mjkkirschner asked, LGTM |
Contributor
Author
|
@mjkkirschner @QilongTang should be good to go now. I didn't remove the stack trace parameter from the |
Contributor
Author
|
All tests passing on the self-serve, merging |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
DYN-1491
This PR removes the stack trace data that got appended to the GitHub new issues url. This was recently introduced in #9393 and has not yet been shipped (only lives in Master not 2.1). There are several issues with making an authenticated request in a browser window in which we are not prepared to handle. More details can be found in #9519 and earlier linked PRs.
It has always been the case that users who do not have a GitHub account cannot report issues. We still gain several improvements with #9393 but automatically copying the stack trace needs to be removed until the team has the bandwidth to implement a more robust solution.
As previously discussed a future solution could be to use a GitHub app. The app could handle/post all crash reports tagging the user by their GitHub id but would be optional allowing all users to report issues. Many in the AEC industry don't use or know much about GitHub.
Declarations
Check these if you believe they are true
*.resxfilesReviewers
@QilongTang @mjkkirschner
FYIs
@radumg