Obsolete LibG221 and 222 usage in DynamoCore#9518
Merged
QilongTang merged 2 commits intomasterfrom Feb 27, 2019
Merged
Conversation
QilongTang
commented
Feb 25, 2019
| // in AssemblyVersionInfo.cs so that it can be easily incremented by the | ||
| // automated build process. | ||
| [assembly: AssemblyVersion("2.1.0.4395")] | ||
| [assembly: AssemblyVersion("2.2.0.4207")] |
Contributor
Author
There was a problem hiding this comment.
ah I forgot to exclude this in master branch but I guess no harm to update the baseline since it is already 2.2
Member
|
I think there are some build copy steps somewhere that should also be removed. |
Contributor
Author
|
@mjkkirschner Addressed comments. I just realized that self CI machine is not updated yet with newer ASM, no wonder there a some regressions there :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please Note:
DynamoRevitrepo will need to be cherry-picked into all the DynamoRevit Release branches that Dynamo supports. Contributors will be responsible for cherry-picking their reviewed commits to the other branches after aLGTMlabel is added to the PR.Purpose
DYN-1618
Remove legacy LibG
Declarations
Check these if you believe they are true
*.resxfilesRunning self CI
Reviewers
@aparajit-pratap
FYIs
@andydandy74 @ZiyunShang @mjkkirschner