[Cherry-picked] 5909 report bug ux tested (#9393)#9414
Merged
mjkkirschner merged 1 commit intoDynamoDS:RC2.1.0_masterfrom Jan 12, 2019
Merged
[Cherry-picked] 5909 report bug ux tested (#9393)#9414mjkkirschner merged 1 commit intoDynamoDS:RC2.1.0_masterfrom
mjkkirschner merged 1 commit intoDynamoDS:RC2.1.0_masterfrom
Conversation
* add /new to GitHubBugReportingLink url * add bug report title to .resx * add support for pre-filled new Github issue text when reporting * Revert resx un-necessary changes * simplify query construction since we make a new Uri, it would never have any existing query parameters * rename variables for legibility * add fallback values for text to prevent null exceptions * invert IF logic to bail early * add XML comment for public method * get rid of conditional logic ✌️ * scaffold unit tests for CrashReporting * add CrashReportingTests.cs to DynamoCoreWpfTests proj * remove public access modifiers * add logged out fallback and make tab detection case-insensitive * move issue text & url formatting to new CrashUtilities.cs file * add test for long stack trace * Revert "Revert resx un-necessary changes" This reverts commit 01fc93c. * add description to issue crash report * fix XML comments * further formatting to crash report * Include issue details from old template * additional new line required * remove browser interaction from unit tests * decrement Dynamo version to make release * comment spelling * spelling - GithhubCrashReportBody becomes GitHubCrashReportBody
Contributor
Author
|
@QilongTang @smangarole I don't have permission to merge |
reddyashish
added a commit
that referenced
this pull request
Jan 14, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original PR
add /new to GitHubBugReportingLink url
add bug report title to .resx
add support for pre-filled new Github issue text when reporting
Revert resx un-necessary changes
simplify query construction
since we make a new Uri, it would never have any existing query parameters
rename variables for legibility
add fallback values for text to prevent null exceptions
invert IF logic to bail early
add XML comment for public method
get rid of conditional logic ✌️
scaffold unit tests for CrashReporting
add CrashReportingTests.cs to DynamoCoreWpfTests proj
remove public access modifiers
add logged out fallback and make tab detection case-insensitive
move issue text & url formatting to new CrashUtilities.cs file
add test for long stack trace
Revert "Revert resx un-necessary changes"
This reverts commit 01fc93c.
add description to issue crash report
fix XML comments
further formatting to crash report
Include issue details from old template
additional new line required
remove browser interaction from unit tests
decrement Dynamo version to make release
comment spelling
spelling - GithhubCrashReportBody becomes GitHubCrashReportBody
FYIs
@QilongTang @smangarole @Racel @radumg