Fix over-indexing of lists and restore string indexing (#9388)#9411
Merged
aparajit-pratap merged 1 commit intoDynamoDS:RC2.1.0_masterfrom Jan 11, 2019
Merged
Conversation
* fix overindexing of lists * add null checks * fixes * revert assemblysharedinfo * fix tests * reverting unchanged file * turn on previously failing tests that pass after fix * revert public to protected * revert unchanged file * fix warning messages
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix overindexing of lists
add null checks
fixes
revert assemblysharedinfo
fix tests
reverting unchanged file
turn on previously failing tests that pass after fix
revert public to protected
revert unchanged file
fix warning messages
Purpose
Cherry-pick #9388
FYIs
@mjkkirschner @QilongTang @smangarole