Use app switch to use old wpf grid layout algorithm to avoid hang on scaled displays.#9374
Merged
mjkkirschner merged 2 commits intoDynamoDS:masterfrom Jan 7, 2019
Merged
Conversation
use config file to set switch
mjkkirschner
changed the title
Contributor
|
So you added the config to DynamoCoreWpf and |
QilongTang
changed the title
mjkkirschner
added a commit
to mjkkirschner/Dynamo
that referenced
this pull request
Jan 7, 2019
use config file to set switch
mjkkirschner
added a commit
that referenced
this pull request
Jan 8, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Adds an app config to DynamoCoreWPF assembly which contains a single key. This key is suggested in this discussion: https://developercommunity.visualstudio.com/content/problem/244615/setfinalsizemaxdiscrepancy-getting-stuck-in-an-inf.html
as a workaround to a bug introduced in the .net 4.7 timeframe into wpf grid control.
I verified I could reproduce the bug (which Aparajit initially found on bootcamp) with my VM using a high resolution 3000 x 2000 ish - at 300% scaling.
Adding this switch here or earlier prevents the hang. Using this we lose whatever enhancements were made to grid resizing in .net 4.7 - but I think a scaled laptop display these days is very common - and not hanging is more important.
with app switch false:
with app switch true:
Declarations
Check these if you believe they are true
*.resxfilesReviewers
@QilongTang
@aparajit-pratap
FYIs
@Racel @smangarole @Dewb