LibG Binaries Update#9371
Merged
QilongTang merged 7 commits intoDynamoDS:masterfrom Jan 4, 2019
DynamoEngOps:master
Merged
Conversation
Contributor
|
@mjkkirschner @alfarok @aparajit-pratap This PR is from the job I triggered after me and @aparajit-pratap finished all the cherry-picks, so should be most up-to-date. Waiting for checks to pass and merge |
Member
|
@QilongTang nice, seems we can merge it - EngOps job will likely fail since it does not have an updated revit - I would guess. (not sure what machine that is) |
Contributor
|
All checks passed, merging. I triggered another job for RC2.1.0 specifically, if job does not succeed, I will cherry-pick this one. |
Contributor
|
@QilongTang I think my cherry-pick was made after your commit above, no? Maybe not, I didn't merge into ASM225 branch so yours would be the last commit that would reflect above. |
QilongTang
added a commit
that referenced
this pull request
Jan 7, 2019
This reverts commit 3591642.
QilongTang
added a commit
that referenced
this pull request
Jan 7, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LibG225
CommitInfo:Aaron Tang - Correct Param order in ligb 225 (#665)
SHA:55977695e0a0aa63c579edaeb14990e15ba908fc
Reviewer: Aaron Tang