Conversation
src/Libraries/CoreNodeModelsWpf/NodeViewCustomizations/DSDropDownBase.cs
Outdated
Show resolved
Hide resolved
|
Hi @QilongTang , it seems like all the subclass of DSDropDownBase would set their SelectedString and save to .dyn files, right? It looks good to me. I would close my PR. |
|
@QilongTang in your manual testing did you also switch the version of revit or only the version of dynamo on which you opened and saved the graphs? To replicate this the number of items or order of them must be changed between saving and loading, which would be accomplished by adding new types (family types) or switching revit version. Seems a unit test could also replicate this issue with some mocked data. |
|
@mjkkirschner See picture I attached, I tested a valid use by opening a DYN saved w/ Dynamo 1.3.3 Revit 2019 in Dynamo 2.2.0 R2020. The selection is differen index between two version. I will make unit tests. |
|
LGTM |
|
@QilongTang this is to cherry pick right? |
|
@mjkkirschner This is for master branch |
|
@QilongTang you don't intend to get this to 2.1 as well? |
|
@mjkkirschner For some reason, the self CI job has been hanging so I can't cherry-pick before that comes out |
* SaveDropDownSelectedItem * Updates to use internal cate * Update comments * Update the syncing logic * Add Dynamo 2.1 Dropdown Unit Tests * Add XML tests * Update Unit tests
* SaveDropDownSelectedItem * Updates to use internal cate * Update comments * Update the syncing logic * Add Dynamo 2.1 Dropdown Unit Tests * Add XML tests * Update Unit tests
Please Note:
DynamoRevitrepo will need to be cherry-picked into all the DynamoRevit Release branches that Dynamo supports. Contributors will be responsible for cherry-picking their reviewed commits to the other branches after aLGTMlabel is added to the PR.Purpose
REVIT-141868
DynamoRevit 2.x Categories Dropdown Produces Inconsistent Results Between Revit versions.
Also fixes DynamoDS/DynamoRevit#2281
I believe this is a more complete version of what you're trying to achieve. @ZiyunShang Let me know how you want to cooperate this task
TODOs:
I have did my manual testing in three basic cases:
Declarations
Check these if you believe they are true
*.resxfilesReviewers
@mjkkirschner @ZiyunShang
FYIs