[Cherry-Pick] API for libG Preloader Lookup (#9324)#9361
Merged
QilongTang merged 1 commit intoRC2.1.0_masterfrom Jan 3, 2019
Merged
[Cherry-Pick] API for libG Preloader Lookup (#9324)#9361QilongTang merged 1 commit intoRC2.1.0_masterfrom
QilongTang merged 1 commit intoRC2.1.0_masterfrom
Conversation
* Add a new static function for preloader lookup * Find the cloest version of preloader from ASM version * Add Unit Test * Address comments * Fix null case and regression * Update Unit test and address comments * Update exception message
Merged
7 tasks
Contributor
Author
|
@mjkkirschner @aparajit-pratap Merging this since the PR in DynamoRevit to consume the new API will be pending until we merge this PR in RC branch and publish the new nugets |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a new static function for preloader lookup
Find the cloest version of preloader from ASM version
Add Unit Test
Address comments
Fix null case and regression
Update Unit test and address comments
Update exception message
Please Note:
DynamoRevitrepo will need to be cherry-picked into all the DynamoRevit Release branches that Dynamo supports. Contributors will be responsible for cherry-picking their reviewed commits to the other branches after aLGTMlabel is added to the PR.Purpose
Cherry-picks #9324 into RC2.1.0
Declarations
Check these if you believe they are true
*.resxfilesReviewers
@mjkkirschner @aparajit-pratap
FYIs