Merged
Conversation
Contributor
|
Thanks @QilongTang! BTW while you're at it could you also remove all references for these older versions such as here: Dynamo/src/DynamoApplications/StartupUtils.cs Line 150 in d80c2b9 |
Contributor
Author
|
@aparajit-pratap Will do. Update: I left mention of 222 in libG tests and public enum untouched, only two appearances left, both removed |
QilongTang
added a commit
that referenced
this pull request
Jan 3, 2019
* Remove Legacy LibG * Remove ASM legacy versions as lookup version params
QilongTang
added a commit
that referenced
this pull request
Jan 7, 2019
This reverts commit 0622384.
QilongTang
added a commit
that referenced
this pull request
Jan 7, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please Note:
DynamoRevitrepo will need to be cherry-picked into all the DynamoRevit Release branches that Dynamo supports. Contributors will be responsible for cherry-picking their reviewed commits to the other branches after aLGTMlabel is added to the PR.Purpose
Since Revit 2020 is finalizing dll lists, this is a good chance for the team to remove the two very old libG folders since there is no need for them to be shipped with Revit 2020. If we do not remove them for now and decide to remove them in a future Dynamo 2.x version, Revit2020 patch update will fail to remove these dlls.
FYI: @aparajit-pratap @mjkkirschner @alfarok @ColinDayOrg @scottmitchell @reddyashish
Declarations
Check these if you believe they are true
*.resxfilesReviewers
@aparajit-pratap
FYIs