Skip to content

Revert "Heterogeneous list update gives infinite loop (#9334)" from 2.1#9355

Merged
QilongTang merged 1 commit intoDynamoDS:RC2.1.0_masterfrom
reddyashish:RC2.1.0_master
Jan 2, 2019
Merged

Revert "Heterogeneous list update gives infinite loop (#9334)" from 2.1#9355
QilongTang merged 1 commit intoDynamoDS:RC2.1.0_masterfrom
reddyashish:RC2.1.0_master

Conversation

@reddyashish
Copy link
Collaborator

@reddyashish reddyashish commented Jan 2, 2019

This reverts commit 67a19a7.

Purpose

This PR is to revert the changes on RC2.1.0 branch.

PR for master branch is #9353

Declarations

Check these if you believe they are true

  • The code base is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning, and are documented in the API Changes document.

Reviewers

@aparajit-pratap

@reddyashish reddyashish mentioned this pull request Jan 2, 2019
Merged
@QilongTang
Copy link
Contributor

QilongTang commented Jan 2, 2019

LGTM

@QilongTang QilongTang added the LGTM Looks good to me label Jan 2, 2019
@mjkkirschner mjkkirschner changed the title Revert "Heterogeneous list update gives infinite loop (#9334)" Revert "Heterogeneous list update gives infinite loop (#9334)" from 2.1 Jan 2, 2019
@QilongTang QilongTang merged commit dea378c into DynamoDS:RC2.1.0_master Jan 2, 2019
mjkkirschner added a commit that referenced this pull request Jan 3, 2019
@mjkkirschner
Revert "Revert "Heterogeneous list update gives infinite loop (#9334)" (
e8814e6 
#9355)"

This reverts commit dea378c.
mjkkirschner added a commit that referenced this pull request Jan 3, 2019
@mjkkirschner
Revert "avoid namespace collisions when collapsing custom nodes RC 2.…
b121ab2 
…1" (#9359)

* Revert "Revert "Heterogeneous list update gives infinite loop (#9334)" (#9355)"

This reverts commit dea378c.

* Revert "fix merge conflicts (#9357)"

This reverts commit 1995db0.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

LGTM Looks good to me

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@reddyashish @QilongTang