Bring search improvements out from behind debug menu#9332
Bring search improvements out from behind debug menu#9332scottmitchell merged 8 commits intoDynamoDS:masterfrom
Conversation
…d debug menu. Deleted debug menu items.
| // return only the top 20 search results | ||
| searchResults = searchResults.Take(20); | ||
|
|
||
| #if DEBUG |
There was a problem hiding this comment.
@ColinDayOrg I'm assuming we want to leave the logging work you did?
There was a problem hiding this comment.
I think so, it's not a lot of logging output and the output could be useful.
There was a problem hiding this comment.
Odd that file comments don't show up here always and vice versa, so repeating here, it's not a lot of logging output and it could be useful (and is only under debug anyways) so I would say yes.
|
just doing another pass at all of this. i think we should change the number of search results to 30. will share the results in a bit. still going through the data |
|
@Racel Just updated to return top 30 instead of top 20. |
| searchResults = searchResults.Take(20); | ||
| } | ||
|
|
||
| // return only the top 30 search results |
There was a problem hiding this comment.
Not that I'm against it, but why the change from 20 to 30 here?
There was a problem hiding this comment.
Just saw the conversation in the main comments, it didn't show up in the file comparison view. This is fine with me.
|
LGTM |
|
Hey guys- so, I did a thorough review of the work against the search analysis results. And, the results look like that people are likely to just type in a new search after not finding it in the top 10. Or on the first page, can we please just set the number back to 20. I think our instincts were correct on this one, and it looks like the data backs that up. See the Jira task for more details. |
|
@Racel That makes sense. I changed it back to 20. |
3 participants
Purpose
This PR updates finalizes improvements to search made in DYN-1326 and DYN-1324. These improvements were initially placed behind the debug menu. This PR brings both improvements out from behind the debug menu and removes them from the debug menu.
Declarations
Check these if you believe they are true
*.resxfilesReviewers
@ColinDayOrg
FYIs
@Racel