Update preview for multi-output node when disconnecting it #9320
Merged
aparajit-pratap merged 2 commits intoDynamoDS:masterfrom Dec 17, 2018
Merged
Update preview for multi-output node when disconnecting it #9320aparajit-pratap merged 2 commits intoDynamoDS:masterfrom
aparajit-pratap merged 2 commits intoDynamoDS:masterfrom
Conversation
Contributor
|
LGTM but why are the data in the preview bubble not aligned in your gif? high resolution display bug? |
Contributor
Author
Yes, I tried to fix it here: #9305 but apparently I'm the only one who sees it on my computer. |
Contributor
|
Thanks @aparajit-pratap, LGTM |
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
JIRA: https://jira.autodesk.com/browse/DYN-1211
This addresses an issue where for any multi-output node, the preview bubble wasn't getting cleared after disconnecting the node from an upstream node. The preview values would remain.
The reason for this is that whenever a node is disconnected, its AST's are recomputed to look something like:
where the node, identified by its output identifier,
var_<guid>, now becomes a function object (or partial function). However for multi-output nodes, the variable identifier was erroneously being set to something else,__partial_<guid>. Since the original node identifier was not being replaced with a function object, it retained its original cached value and when it was queried in the preview bubble, it returned the original value as expected. The fix is to replace the new identifier with the original one so that it can be reset to a function object when the node is disconnected.Declarations
Check these if you believe they are true
*.resxfilesNeed to run self-serve and add tests - WIP
Reviewers
@alfarok
FYIs
@Racel