Skip to content

Update preview for multi-output node when disconnecting it #9320

Merged
aparajit-pratap merged 2 commits intoDynamoDS:masterfrom
aparajit-pratap:multiout
Dec 17, 2018
Merged

Update preview for multi-output node when disconnecting it #9320
aparajit-pratap merged 2 commits intoDynamoDS:masterfrom
aparajit-pratap:multiout

Conversation

@aparajit-pratap
Copy link
Contributor

@aparajit-pratap aparajit-pratap commented Dec 17, 2018

Purpose

JIRA: https://jira.autodesk.com/browse/DYN-1211

This addresses an issue where for any multi-output node, the preview bubble wasn't getting cleared after disconnecting the node from an upstream node. The preview values would remain.

The reason for this is that whenever a node is disconnected, its AST's are recomputed to look something like:

var_<node_guid> = __CreateFunctionObject(...);

where the node, identified by its output identifier, var_<guid>, now becomes a function object (or partial function). However for multi-output nodes, the variable identifier was erroneously being set to something else, __partial_<guid>. Since the original node identifier was not being replaced with a function object, it retained its original cached value and when it was queried in the preview bubble, it returned the original value as expected. The fix is to replace the new identifier with the original one so that it can be reset to a function object when the node is disconnected.

screenshot

Declarations

Check these if you believe they are true

  • The code base is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
    Need to run self-serve and add tests - WIP
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning, and are documented in the API Changes document.

Reviewers

@alfarok

FYIs

@Racel

@QilongTang
Copy link
Contributor

LGTM but why are the data in the preview bubble not aligned in your gif? high resolution display bug?

@aparajit-pratap
Copy link
Contributor Author

LGTM but why are the data in the preview bubble not aligned in your gif? high resolution display bug?

Yes, I tried to fix it here: #9305 but apparently I'm the only one who sees it on my computer.

@alfarok
Copy link
Contributor

alfarok commented Dec 17, 2018

Thanks @aparajit-pratap, LGTM

@alfarok alfarok added the LGTM Looks good to me label Dec 17, 2018
@aparajit-pratap aparajit-pratap merged commit 28bbd9b into DynamoDS:master Dec 17, 2018
@aparajit-pratap aparajit-pratap deleted the multiout branch December 17, 2018 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

LGTM Looks good to me

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants