libG copy steps should have the same behavior as before.#9311
Merged
mjkkirschner merged 5 commits intoDynamoDS:masterfrom Dec 13, 2018
Merged
libG copy steps should have the same behavior as before.#9311mjkkirschner merged 5 commits intoDynamoDS:masterfrom
mjkkirschner merged 5 commits intoDynamoDS:masterfrom
Conversation
modify dynamoCore libG copy step to copy all libG folders
Contributor
|
@mjkkirschner Let's address this case sensitive thing when we move to nugets, the fix looks good to me. |
Contributor
|
@mjkkirschner does this pose an issue in Windows? How and when does it surface? |
Contributor
|
@aparajit-pratap |
Member
Author
|
@aparajit-pratap on windows this will cause issues if a user has enabled file system case sensitivity which is now an option in windows 10. 😬 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
@QilongTang noticed a change in the libG folder names copied the bin directory.
I'm not a fan of the libG folders in extern being
LibG_and those in bin beinglibG_- but I think this is the least risky change at this point.Normally this should not be a problem on standard windows, but it might be on mono, mac, linux platforms.
This PR just reverts the copy steps to their previous behavior.
Some alternatives:
var libGFolderName = string.Format("Libg_{0}_{1}_{2}", major, minor, build);instead of the lowercase libG.Looking for some feedback/thoughts.
Declarations
Check these if you believe they are true
*.resxfilesReviewers
@QilongTang
@aparajit-pratap
FYIs
@smangarole