UI fix for Dictionary label in node preview#9305
Closed
aparajit-pratap wants to merge 3 commits intoDynamoDS:masterfrom
Closed
UI fix for Dictionary label in node preview#9305aparajit-pratap wants to merge 3 commits intoDynamoDS:masterfrom
aparajit-pratap wants to merge 3 commits intoDynamoDS:masterfrom
Conversation
Member
|
LGTM |
Contributor
|
@aparajit-pratap Was just reviewing this UI with Keith and we can not reproduce the hidden letters on his machine. Please do not merge as it is working fine on his. |
Contributor
|
Strange it looks okay on my machine |
Contributor
Author
|
Ok, thanks. I'll close this one. There's something weird that could be going on with my display. Please let me know if any of you can reproduce this at a later point of time. |
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This fixes the
Dictionarytop-level label in the node preview. The text was partially cut-off - more specifically theDinDictionary. The reason was that the top-level label had a different margin setting than nested labels. This fix removes the special setting for top-level labels and keeps just one margin setting for both top and nested labels.Before:
After:
Declarations
Check these if you believe they are true
*.resxfilesReviewers
@mjkkirschner
@Racel - this requires your UX review as the top-level labels for both
ListandDictionarytexts are shifted 4 units to the right and are the same as nested labels. Note that I couldn't find an alternative way of fixing this UI issue.