QNTM-5867 Search dictionary should only be recreated when necessary#9301
Merged
scottmitchell merged 6 commits intoDynamoDS:masterfrom Dec 12, 2018
Merged
QNTM-5867 Search dictionary should only be recreated when necessary#9301scottmitchell merged 6 commits intoDynamoDS:masterfrom
scottmitchell merged 6 commits intoDynamoDS:masterfrom
Conversation
Contributor
|
LGTM |
Member
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This PR addresses jira task QNTM-5867: Search dictionary should only be recreated when necessary. It creates a TagDictionary property that is cached and only recreated when necessary. The tag dictionary used to be a local variable that was recreated with every single search.
This PR does:
This PR does NOT:
Declarations
Check these if you believe they are true
*.resxfilesReviewers
@ColinDayOrg @mjkkirschner
FYIs