Fix crash with incorrect syntax in CBN in custom node#9258
Merged
aparajit-pratap merged 3 commits intoDynamoDS:masterfrom Nov 26, 2018
Merged
Fix crash with incorrect syntax in CBN in custom node#9258aparajit-pratap merged 3 commits intoDynamoDS:masterfrom
aparajit-pratap merged 3 commits intoDynamoDS:masterfrom
Conversation
Member
|
@aparajit-pratap thanks for the explanation LGTM - |
Contributor
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
JIRA: https://jira.autodesk.com/browse/QNTM-4425
GH Issue: #8911
The crash occurs at the time of compilation of the custom node definition. It tries to build a
returnAST statement with the output from the code block node but since the code block output isnullowing to the syntax error, anArgumentNullExceptionis thrown from theAstFactory.BuildReturnStatement, which apparently isn't caught anywhere and results in a crash. The fix is to build aNullNodeif the rhs returned from the code block AST isnulland then pass thisNullNodeas input to theBuildReturnStatementmethod to generate AST for areturn = null;statement.Declarations
Check these if you believe they are true
*.resxfilesReviewers
@mjkkirschner @QilongTang @ColinDayOrg
Adding a test case would be tricky here - it would be best to add a recordable test but I'm not sure if we can add these for a custom node workspace. Will check.