Support namespace qualifiers in classes used in Imperative blocks#9252
Merged
aparajit-pratap merged 10 commits intoDynamoDS:masterfrom Nov 19, 2018
Merged
Support namespace qualifiers in classes used in Imperative blocks#9252aparajit-pratap merged 10 commits intoDynamoDS:masterfrom
aparajit-pratap merged 10 commits intoDynamoDS:masterfrom
Conversation
aparajit-pratap
changed the title
| return newIdentList; | ||
| } | ||
|
|
||
| public static AST.ImperativeAST.ImperativeNode CreateNodeByCombiningIdentifiers(IList<AST.ImperativeAST.ImperativeNode> nodeList) |
Member
There was a problem hiding this comment.
summary tag for public method?
Member
There was a problem hiding this comment.
Any reason not to use an IEnumerable for a public method?
Member
There was a problem hiding this comment.
Ah sorry, did not see it was an IList
Contributor
|
Generally, LGTM, although it is a little difficult to parse some of the changes. Also, there are some sections of code that were commented out, but left in, was this for any specific reason? |
aparajit-pratap
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Support namespace qualifiers in classes used in Imperative blocks: https://jira.autodesk.com/browse/QNTM-5647
Declarations
Check these if you believe they are true
*.resxfilesReviewers
@mjkkirschner @QilongTang @ColinDayOrg
FYIs
@smangarole