We are also initializing CEF here:

I don't know if that ever happens but it should follow the same pattern.

Ahh good catch!

@saintentropy I am still curious why I can't get three.js to launch in D4R 2018. This was the check I was using for WebGL

if (webglAvailable()) {
    renderer = new THREE.WebGLRenderer( { antialias: false, alpha: true } );
} else {
    renderer = new THREE.CanvasRenderer();
    defaultShadedMaterial = new THREE.MeshBasicMaterial({ color: 0x00ff00 });
}

function webglAvailable() {
try {
    var canvas = document.createElement('canvas');
    return !!(window.WebGLRenderingContext && (
        canvas.getContext('webgl') ||
        canvas.getContext('experimental-webgl'))
    );
} catch (e) {
    return false;
}

Anyway, this LGTM. We should keep a close eye on conflicts between multiple CEF reliant apps, especially librarie.js. I also came across this line which is slightly different in package manager UI (which isn't implemented) but it seems the Singapore team consistently disabled the GPU when using CEF.

• Have you verified that as a revit addin you can start a webgl enabled cef window?
• noticed any issues with library after this change?

@mjkkirschner 1) Yes we have verified that and 2) no we have noticed specific issues with Library although there are still intermittent issues with Library that seem to occur independent of this settings change. Specifically, the notes in the older commits were about flickering. That has not be observed in our use... perhaps CEF version changes since then have improved that defect. Regardless, whatever we observe with this change is what is currently observed by users in Revit 2018, 2019, 2020.

All Self service tests appears to pass except 1 that is also failing on master

@saintentropy just pinged @smangarole on this. I believe some recent changes by Luke may be causing failures so we are working to get that sorted out

Ok thanks @alfarok I will go ahead and merge and wait for the test to be resolved.