QNTM-4488: Fix AST creation for partial multi-outport custom nodes#8928
Merged
aparajit-pratap merged 1 commit intoDynamoDS:masterfrom Jun 15, 2018
Merged
Conversation
Member
|
@aparajit-pratap nice! will this magically fix this as well (I am guessing no 😉 ) |
Collaborator
|
@aparajit-pratap @mjkkirschner @smangarole Should the title etc of QNTM-4488 be updated? |
Contributor
Author
|
@jnealb I've updated the JIRA title. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Fix for incorrect warning displayed with partial multi-output custom node when compiled to Dictionary.

Previously the compiled AST generated for such a node was:
This should be compiled to:
JIRA: https://jira.autodesk.com/browse/QNTM-4488
Declarations
Check these if you believe they are true
*.resxfilesReviewers
@mjkkirschner
FYIs
@kronz @jnealb