Fix type checking for integers on IsOutput serialization#8810
Fix type checking for integers on IsOutput serialization#8810saintentropy merged 3 commits intoDynamoDS:masterfrom
Conversation
|
@saintentropy can you also fix this in the inputNodeData class - will it matter there? |
|
@saintentropy @mjkkirschner @smangarole @ramramps @aparajit-pratap I have to ask one last time: is this code flaw possibly anywhere else? |
|
InputNodeData.cs |
|
NodeInputData.cs has the same enum types here... The reason it wasn't required is that we type the integer slider with an |
|
Our integer type is int64 in 2.0 |
|
yeah, I think it might be an improvement to change slider to int64. |
|
@mjkkirschner... Let's do this. Let me change the enum of supported types on NodeInputData.cs so that we are covered on type checking regardless of what happens on the Slider. |
|
@saintentropy Do you mind adding unit test, and you are good to go for 2.0.1, let us know because code freeze for 2.0.1 is by end of Inception Sprint |
|
@QilongTang Test added :-) |
|
@saintentropy Hi, I saw test files added but no unit tests code change, did we miss some commits here? |
|
@QilongTang This code is validated via the serialization tests. |
|
@saintentropy @QilongTang @Racel @smangarole @mjkkirschner Note that despite the mention of 2.0.1 above the JIRA task QNTM-4085 is marked for 2.1. Is this correct? |
|
@saintentropy Thank you for the confirmation, changes LGTM @jnealb That is correct, I removed the 2.0.1 tag of this PR. So this will be a 2.1 issue only |
Purpose
The purpose of this PR is to correct a bug in the serialization of nodes using the IsOutput UI. Previously nodes with a return type of integer were being set as Unknown. This issue is tracked with
QNTM-4085 and is a dependency of QNTM-3458.
Declarations
Check these if you believe they are true
*.resxfilesReviewers
@QilongTang @ramramps
FYIs
@nonoesp