Skip to content

Fix the test from PR : https://github.com/DynamoDS/Dynamo/pull/8655#8658

Merged
ramramps merged 1 commit intoDynamoDS:masterfrom
ramramps:Units-conversion-issue
Mar 15, 2018
Merged

Fix the test from PR : https://github.com/DynamoDS/Dynamo/pull/8655#8658
ramramps merged 1 commit intoDynamoDS:masterfrom
ramramps:Units-conversion-issue

Conversation

@ramramps
Copy link
Collaborator

Purpose

Fixed the test from PR : #8655

Declarations

Check these if you believe they are true

  • The code base is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning, and are documented in the API Changes document.

Reviewers

(FILL ME IN) Reviewer 1 (If possible, assign the Reviewer for the PR)

(FILL ME IN, optional) Any additional notes to reviewers or testers.

FYIs

(FILL ME IN, Optional) Names of anyone else you wish to be notified of

@ramramps ramramps merged commit 9a01a0c into DynamoDS:master Mar 15, 2018
@ramramps ramramps mentioned this pull request Mar 15, 2018
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant