CubicMillimeter To CubicMeter conversion#8650
Merged
ramramps merged 1 commit intoDynamoDS:masterfrom Mar 14, 2018
Merged
Conversation
| converterNode.SelectedFromConversion = ConversionUnit.CubicMillimeter; | ||
| converterNode.SelectedToConversion = ConversionUnit.CubicMeters; | ||
| ViewModel.HomeSpace.Run(); | ||
| Thread.Sleep(500); |
Member
There was a problem hiding this comment.
did you find this was required?
Collaborator
Author
There was a problem hiding this comment.
I don't know whether this is required. May be I should remove this and run the self serve CI. This code is 3 year old now.
Member
There was a problem hiding this comment.
I'm confused, this looks like new code you added?
Collaborator
Author
There was a problem hiding this comment.
Nope..the other thread.sleep code. I removed this, and running self serve CI
Member
There was a problem hiding this comment.
oh I see, that was following the pattern.
Member
|
LGTM (if that test passes) |
Collaborator
Author
|
Tests passed. 11940 tests Merging this. |
Collaborator
Author
|
oh man.. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Task : https://jira.autodesk.com/browse/QNTM-1304
This PR fixes the bug in conversion between CubicMillimeter to CubicMeter
Declarations
Check these if you believe they are true
*.resxfilesReviewers
@mjkkirschner