Skip to content

Update NuGet.exe#8425

Merged
aparajit-pratap merged 1 commit intomasterfrom
NuGetUpdate
Jan 2, 2018
Merged

Update NuGet.exe#8425
aparajit-pratap merged 1 commit intomasterfrom
NuGetUpdate

Conversation

@smangarole
Copy link
Contributor

@smangarole smangarole commented Jan 2, 2018

Please Note:

  1. Before submitting the PR, please review How to Contribute to Dynamo
  2. Dynamo Team will meet 1x a month to review PRs found on Github (Issues will be handled separately)
  3. PRs will be reviewed from oldest to newest
  4. If a reviewed PR requires changes by the owner, the owner of the PR has 30 days to respond. If the PR has seen no activity by the next session, it will be either closed by the team or depending on its utility will be taken over by someone on the team
  5. PRs should use either Dynamo's default PR template or one of these other template options in order to be considered for review.
  6. PRs that do not have one of the Dynamo PR templates completely filled out with all declarations satisfied will not be reviewed by the Dynamo team.
  7. PRs made to the DynamoRevit repo will need to be cherry-picked into all the DynamoRevit Release branches that Dynamo supports. Contributors will be responsible for cherry-picking their reviewed commits to the other branches after a LGTM label is added to the PR.

Purpose

Update the NuGet.exe version to 4.4.1. Nuget requires all packages to be pushed with minimum client version 4.1.0.

Declarations

Check these if you believe they are true

  • The code base is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate

(https://github.com/DynamoDS/Dynamo/wiki/Dynamo-Versions), and are documented in the API Changes document.

Reviewers

@QilongTang

FYIs

@aparajit-pratap @mjkkirschner

@QilongTang
Copy link
Contributor

LGTM but Re-started the EngOps Build check, it failed however on first run

@aparajit-pratap
Copy link
Contributor

@QilongTang I think the build machine for the EngOps build check is using an older version of VisualStudio (.NET) that's giving errors with some new C# features?

@aparajit-pratap
Copy link
Contributor

@smangarole @QilongTang the EngOps build errors are also failing due to out of disk space errors on the build machine. I don't think these are related to this PR, so I'm going ahead with merging.

@aparajit-pratap aparajit-pratap merged commit 915e6c7 into master Jan 2, 2018
@QilongTang QilongTang deleted the NuGetUpdate branch January 2, 2018 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants