Remove icons from Geometry class sub-categories#8369
Merged
alfarok merged 6 commits intoDynamoDS:masterfrom Dec 8, 2017
Merged
Remove icons from Geometry class sub-categories#8369alfarok merged 6 commits intoDynamoDS:masterfrom
alfarok merged 6 commits intoDynamoDS:masterfrom
Conversation
Member
Contributor
|
I agree with @mjkkirschner. We need a more general solution. Nested categories should never have an icon. |
Contributor
Author
|
@mjkkirschner @Racel okay, no problem. The task description and AC discussed removing them or making them visually distinct for clarity so I wasn't sure if we wanted to completely remove all referenced code or if it's something that was going to be revisited down the line. |
7 tasks
alfarok
changed the title
Member
|
Can this be merged ? |
Contributor
Author
|
@mjkkirschner yes will merge now along with this librarie PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
QNTM-2675
Supplemental Librarie PR
The purpose of this PR is to remove the icons from the Geometry class sub-categories. The icons beside the Geometry categories is confusing as they look like nodes and not sub-categories.
This PR simply includes the updated
Librarie.min.jsfile. The modifications take place in this Librarie PR where any Element Type categorized asnonedoes not load an icon. This is the same logicgrouptypes follow.Documentation
Updated Wiki
For more info on Element Types see the Librarie Docs
Declarations
Check these if you believe they are true
*.resxfilesReviewers
@mjkkirschner
FYIs
@Racel