Duplicate connectors on ctrl + click on input ports#7850
Closed
yeexinc wants to merge 2 commits intoDynamoDS:masterfrom
Closed
Duplicate connectors on ctrl + click on input ports#7850yeexinc wants to merge 2 commits intoDynamoDS:masterfrom
yeexinc wants to merge 2 commits intoDynamoDS:masterfrom
Conversation
Contributor
|
Functionality wise this is what I was looking, so LGTM from my side. @benglin Can you please do the code review? Thanks, |
benglin
reviewed
May 9, 2017
|
|
||
| case MakeConnectionCommand.Mode.EndAndStartCtrlConnection: | ||
| EndAndStartCtrlConnection(nodeId, command.PortIndex, command.Type); | ||
| break; |
Contributor
There was a problem hiding this comment.
Hi @yeexinc, after further considerations I think better names for the modes would be BeginDuplicateConnection and BeginCreateConnections. Please also rename the methods to reflect this.
benglin
reviewed
May 9, 2017
| activeStartPorts = new PortModel[] { portModel.Connectors[0].Start }; | ||
| firstStartPort = portModel.Connectors[0].Start; | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
Will the undo work for each of the connectors created?
Contributor
Author
There was a problem hiding this comment.
@benglin - Yes, each undo action corresponds to one connector created.
Contributor
|
@QilongTang - I think we just need to add this to our backlog. Let us just try to merge this in if you think it looks good to go. Adding a task for this. |
7 tasks
7 tasks
Contributor
|
closing and picking this work up in #9567 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Duplicate connectors when the user does a ctrl + click on input ports.
Declarations
Check these if you believe they are true
*.resxfilesReviewers
@benglin
@riteshchandawar