Added ScaleFactor property to WorkspaceModel and corresponding WorkspaceEvent#6967
Merged
aparajit-pratap merged 3 commits intoDynamoDS:masterfrom Aug 4, 2016
Merged
Conversation
| /// <summary> | ||
| /// An event raised when workspace ScaleFactor setting is changed. | ||
| /// </summary> | ||
| /// <param name="scaleFactor"></param> |
Contributor
There was a problem hiding this comment.
I guess the XML comments here should have been intended for the public event instead of the internal method.
And it would be good if we do not introduce new empty lines in this PR. Thanks @aparajit-pratap! 😄
Contributor
Author
|
Done, thanks @ellensi for reviewing this. |
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This PR is for MAGN-10468 to subscribe to workspace events in Dynamo from external libraries like ProtoGeometry and pass on the scaling factor set in the Dynamo UI.
This is necessary for the UI task to prompt the user for the geometry scaling factor and setting it in the DYN file .
Declarations
Check these if you believe they are true
*.resxfilesReviewers
@ellensi