Replaced IWatch3DView with IWatch3DViewModel interface to expose api's to extensions#5418
Conversation
There was a problem hiding this comment.
I'm okay with this file being under Watch3D instead of Interfaces folder, but I guess we should really start documenting our public contracts. A role model of API documentation can be found for IViewExtension, which explains the purposes, the acceptable argument values, and the expected return values. I was thinking about adding a new YT task to track this but since this is new/small, we might as well just add some here and be done with it. Does that make sense?
There was a problem hiding this comment.
The interfaces folder is most likely going away, BTW, when we do the namespace reorganization next sprint. I agree that we need to document every one of our public contracts. See http://adsk-oss.myjetbrains.com/youtrack/issue/MAGN-8392.
|
Some minor comments, and we'll be good to go! |
|
@benglin done. |
Replaced IWatch3DView with IWatch3DViewModel interface to expose api's to extensions
3 participants
Purpose
This PR addresses the task to swap
IWatch3DViewwithIWatch3DViewModelas per the design discussed in #5314.The new
BackgroundViewModelproperty of the newIWatch3DViewModeltype is exposed inViewLoadedParamscurrently being used by https://git.autodesk.com/Dynamo/DynamoPro/pull/179.Declarations
*.resxfilesReviewers
@benglin Reviewer 1
FYIs
@ikeough