Purpose

This pull request is meant to fix multiple wonky Dynamo execution issues that have recently been reported. The crux of the issue lies with multiple execution requests have been dropped due to an incorrect condition that guards against further execution in HomeWorkspaceModel.Run. Take for example the following graph:

When the code block node is updated from x to 9, the following calls take place in sequence (they indirectly invoke HomeWorkspaceModel.Run method):

1. Dynamo.Nodes.CodeBlockNodeModel.SaveAndDeleteConnectors(...)
2. Dynamo.Nodes.CodeBlockNodeModel.LoadAndCreateConnectors(...)
3. Dynamo.Nodes.CodeBlockNodeModel.SetCodeContent(...)

Since step 1 sets RunSettings.RunEnabled = false, subsequently steps 2 and 3 do not result in UpdateGraphAsyncTask being scheduled (even though HomeWorkspaceModel.Run is called, it returns prematurely). Step 3 is crucial because it ultimately generates AST node with the right value for execution, without that, downstream node executes with wrong input:

The same sequence of events take place when code block node is then updated to 5, except the fact that downstream node no longer get any input (which turned it into a partially applied _SingleFunctionObject):

Declarations

Check these if you believe they are true

• The code base is in a better state after this PR
• The level of testing this PR includes is appropriate

Reviewers

Hi @sharadkjaiswal, as discussed, please have a look.

FYIs

Hi @lukechurch, @ikeough, @Randy-Ma feel free to comment on this. If the review is completed earlier, I will merge this in for wider testing.

Hi @monikaprabhu, this pull request effectively reverts the code changes in another pull request. For that, I have verified the fix for MAGN-7251 remained fixed (since selection nodes get disabled when Revit document changes), but please perform more thorough tests on relevant scenarios. Thanks!