Part 1 of fixing MAGN-7251 [Regression from 0.7.5] Select elements will cause a crash after switching Revit documents#4594
Merged
User-Zhaoyang merged 1 commit intoDynamoDS:masterfrom Jun 3, 2015
Conversation
2 tasks
Contributor
There was a problem hiding this comment.
Wow this is new, what scenario is this meant to solve? It'll be nice to add a comment to explain why this is important here so future readers.
Contributor
Author
There was a problem hiding this comment.
There have been some comments about this in the summary. Hmmm, I will add some comments here as well.
Contributor
There was a problem hiding this comment.
Thanks for the clarifications, @Randy-Ma. The comments did help!
…ll cause a crash after switching Revit documents
User-Zhaoyang
pushed a commit
that referenced
this pull request
Jun 3, 2015
Part 1 of fixing MAGN-7251 [Regression from 0.7.5] Select elements will cause a crash after switching Revit documents
User-Zhaoyang
pushed a commit
that referenced
this pull request
Jun 4, 2015
Part 1 of fixing MAGN-7251 [Regression from 0.7.5] Select elements will cause a crash after switching Revit documents #4594
horatiubota
added
the
error/warning/crash
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This is the first part to fix MAGN-7251. There are two changes here:
1). To ensure when the CanSelect property changes in SelectionBase, the UI updates.
2). When RunSettings.RunEnabled is false, the workspace should not run. This is already like this for the manual mode, because the run button is disabled. But for the automatic mode, the workspace's Run method can still be called. This submission will avoid this.
Declarations
Check these if you believe they are true
Reviewers
@benglin
FYIs