Merged
Conversation
MaximumItem and MinimumItem don't handle mixed array of integer and double values properly. Fixed by using DoubleConverter as item selector for Min() and Max methods. Fixes http://adsk-oss.myjetbrains.com/youtrack/issue/MAGN-3992
Contributor
Author
Contributor
|
Does |
Contributor
|
Otherwise LGTM |
- Updated the input argument type as IEnumerable<object> so that the argument is marshaled as 1D collection, and hence it will replicate on multi-dimension collection. - On multi dimension collection these methods fail or behave wrong. It should replicate and return values from each collection. - Fixed http://adsk-oss.myjetbrains.com/youtrack/issue/MAGN-3567
Contributor
Author
|
Are we making any assumption about double? It works on all objects of same type that implement IComparer, but integer and double are interchangeable in Dynamo and hence we should be able to cast integers to double, else we leave rest of the objects as it is. |
…3992 Conflicts: test/DynamoCoreTests/Nodes/ListTests.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MaximumItem and MinimumItem don't handle mixed array of integer and
double values properly.
methods.
MaximumItem, MinimumItem and Sort methods don't replicate.