DYN-10020 - Revise Sample File Directory Traversing#16820
DYN-10020 - Revise Sample File Directory Traversing#16820zeusongit merged 5 commits intoDynamoDS:masterfrom
Conversation
There was a problem hiding this comment.
See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-10020
There was a problem hiding this comment.
Pull request overview
This PR improves the sample file directory traversal logic by filtering out dependency folders and empty directories from the sample file tree.
Key Changes:
- Adds filtering to exclude directories ending with ".dependencies" from the sample file tree
- Implements empty directory filtering by only adding directories that contain .dyn files (directly or in subdirectories)
thank you mr copilot 🤓 Co-authored-by: Copilot <[email protected]>
| { | ||
| //Make sure the folder's name is not "backup" | ||
| if (!directory.Name.Equals(Configurations.BackupFolderName)) | ||
| // Make sure that the folder name is not "backup" and that it doesn't end with ".dependencies". |
There was a problem hiding this comment.
Thinking more about it maybe we should exclude all GD samples. Player I think they're fine.
GD samples are more complex and require some familiarity with GD and the starting point for that should be the GD app I guess.
There was a problem hiding this comment.
That might be a bit more difficult as file names can change? Should we just ignore a top level directory if any sub directory contains a .dependencies folder?
There was a problem hiding this comment.
We can check if the dyn has an active linter (Generative Design), and if it does filter it out?
There was a problem hiding this comment.
Just added the logic for filtering based on linter.
There was a problem hiding this comment.
I think we can just exclude the folder named GD ?
Co-authored-by: Copilot <[email protected]> (cherry picked from commit c70e506)
|
Successfully created backport PR for |
Purpose
Issue: WalkDirectoryTree in StartPage.xaml.cs adds directory entries even if they contain no .dyn files. It filters .dyn files, but directories are added before checking for children.
This PR improves the sample file directory traversal logic by filtering out dependency folders and empty directories from the sample file tree.
Key Changes:
Adds filtering to exclude directories ending with ".dependencies" from the sample file tree
Implements empty directory filtering by only adding directories that contain .dyn files (directly or in subdirectories)
Summary
Added filtering to exclude
.dynfiles with "Generative Design" as the active linter.Changes Made
JSON Handling
using Newtonsoft.Json.Linq;to handleJObjectinstances from JSON deserialization.Home Page Filtering Behavior
The home page now filters out:
.dynfiles.dependenciesor equal togd.dynfilesAfter Fix:

Declarations
Check these if you believe they are true
Release Notes
Reviewers
@DynamoDS/eidos
FYIs
@emru-y