9515: DYN-9819: Refactor dynamo toasts into separate public class#16681
9515: DYN-9819: Refactor dynamo toasts into separate public class#16681chubakueno merged 6 commits intoDynamoDS:masterfrom
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-9515
There was a problem hiding this comment.
Pull Request Overview
This PR refactors toast notification functionality from the GuidesManager class into a new separate public ToastManager class, making toast notifications accessible to external packages. This addresses a TODO item from a previous pull request.
Key Changes:
- Created new
ToastManagerclass to handle toast notifications - Updated all references from
MainGuideManagertoToastManagerfor toast-related operations - Made toast notification API publicly accessible via the new class
Reviewed Changes
Copilot reviewed 20 out of 20 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/DynamoCoreWpf/UI/ToastManager.cs | New public class implementing toast notification functionality |
| src/DynamoCoreWpf/UI/GuidedTour/GuidesManager.cs | Removed toast notification code and delegated to ToastManager |
| src/DynamoCoreWpf/ViewModels/Core/DynamoViewModel.cs | Added ToastManager property and updated references |
| src/DynamoCoreWpf/Views/Core/DynamoView.xaml.cs | Initialized ToastManager and updated location handling |
| src/DynamoCoreWpf/PublicAPI.Unshipped.txt | Added public API surface for ToastManager |
| src/DynamoCoreWpf/DynamoCoreWpf.csproj | Registered new ToastManager.cs file in project |
| test/DynamoCoreWpfTests/DynamoViewTests.cs | Updated test to use ToastManager.PopupIsVisible |
| Multiple UI/ViewModel files | Updated toast notification calls from MainGuideManager to ToastManager |
| Multiple extension files | Updated toast notification calls from MainGuideManager to ToastManager |
johnpierson
changed the title
github-actions
bot
changed the title
johnpierson
changed the title
github-actions
bot
changed the title
|
Just saw this update, and I think if we may have to cherry pick this change to 4.0, as PythonNet3 also gets affected by this change, and at some point we will cherry-pick that as well. FYI @QilongTang |
Please go ahead |
|
/cherrypick |
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin RC4.0.0_master
git worktree add -d .worktree/cherrypick-16681 origin/RC4.0.0_master
cd .worktree/cherrypick-16681
git switch --create cherrypick-16681
git cherry-pick -x 1d40b1313b90e735b3f848f66a62531fb07d5e43 |
|
/cherrypick |
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin RC4.0.0_master
git worktree add -d .worktree/cherrypick-16681 origin/RC4.0.0_master
cd .worktree/cherrypick-16681
git switch --create cherrypick-16681
git cherry-pick -x 1d40b1313b90e735b3f848f66a62531fb07d5e43 |
Purpose
Refactor dynamo toasts into separate public class, which was a pending todo since #12970
Declarations
Check these if you believe they are true
Release Notes
External packages will now have access to the creation of toasts.
Reviewers
@johnpierson
FYIs
@QilongTang
@avidit