[Cherry-pick] DYN-9679: Auto-revert to ObjectType when ML autocomplete agreement is unchecked#16620
Merged
zeusongit merged 1 commit intoRC4.0.0_masterfrom Oct 22, 2025
Merged
Conversation
… unchecked (#16616) Co-authored-by: Aaron (Qilong) <[email protected]> (cherry picked from commit f88de06)
3 tasks
QilongTang
approved these changes
Oct 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #16616 to
RC4.0.0_masterPurpose
When users uncheck the "Agreement for Data Collection" checkbox for ML-based node autocomplete, the system now automatically reverts to ObjectType matching mode.
Problem:
Users could uncheck the ML agreement but remain in ML recommendation mode, they had to manually switch back to ObjectType mode
Solution:
Added automatic fallback logic in
IsMLAutocompleteTOUApprovedsetterDeclarations
Check these if you believe they are true
Release Notes
ML autocomplete now automatically reverts to ObjectType matching when users uncheck the data collection agreement.
Reviewers
@DynamoDS/eidos @DynamoDS/synapse
FYIs
(FILL ME IN, Optional) Names of anyone else you wish to be notified of