DYN-9244 ProgramData Samples Installer#16611
Merged
QilongTang merged 4 commits intoDynamoDS:masterfrom Oct 20, 2025
Merged
Conversation
When the DynamoBuildScripts job is running is using the solution Install.sln for generating the Dynamo installer and the zipped file, so the wix project was excluding the samples folder from the final release, with this fix I'm removing the code that is excluding the samples folder.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR modifies the Dynamo installer configuration to include the samples folder in the final installer package. Previously, the WiX installer project was explicitly excluding the samples folder from both the file harvesting process and the installer build.
- Removes XSL template rules that excluded samples directories and components
- Updates robocopy command to stop excluding the samples directory during file harvesting
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/DynamoInstall/Release.xsl | Removes XSL templates that excluded samples directories and components from the installer |
| src/DynamoInstall/DynamoInstall.wixproj | Updates robocopy command to remove -XD samples exclusion parameter |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-9244
Contributor
|
@RobertGlobant20 I guess this #16610 should fix the failure in your build |
QilongTang
approved these changes
Oct 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Modify the wix project to not excluding the samples folder
When the DynamoBuildScripts job is running is using the solution Install.sln for generating the Dynamo installer and the zipped file, so the wix project was excluding the samples folder from the final release, with this fix I'm removing the code that is excluding the samples folder.
Declarations
Check these if you believe they are true
Release Notes
Modify the wix project to not excluding the samples folder
Reviewers
@QilongTang @avidit
FYIs
(FILL ME IN, Optional) Names of anyone else you wish to be notified of