[DYN-9407] Handle PhoneticRun elements for import-excel node#16607
[DYN-9407] Handle PhoneticRun elements for import-excel node#16607reddyashish merged 3 commits intoDynamoDS:masterfrom
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-9407
aparajit-pratap
left a comment
aparajit-pratap
left a comment
There was a problem hiding this comment.
Can you add a test case?
There was a problem hiding this comment.
Pull Request Overview
Adds logic to exclude PhoneticRun elements (phonetic guides) from extracted shared string values when importing Excel via OpenXML.
- Replaces direct InnerText access with a new helper that filters out phonetic runs.
- Introduces GetSharedStringText and IsInsidePhoneticRun helper methods to process SharedStringItem contents.
| if (cell.CellValue.TryGetInt(out var index)) | ||
| { | ||
| return sharedStringTable.ElementAt(index).InnerText; | ||
| return GetSharedStringText(sharedStringTable.ElementAt(index)); |
There was a problem hiding this comment.
sharedStringTable.ElementAt(index) will iterate to the index each call; if this method executes for many cells, prefer direct indexed access (e.g., sharedStringTable.ChildElements[index] or caching Elements().ToList()) to avoid repeated enumeration.
|
@aparajit-pratap added the test and addressed comments. |
Purpose
DYN-9407
Handling PhoneticRun elements for excel nodes (https://learn.microsoft.com/en-us/dotnet/api/documentformat.openxml.spreadsheet.phoneticrun?view=openxml-3.0.1). These characters should not be displayed when using OpenXMLImportExcel node.
Declarations
Check these if you believe they are true
Release Notes
[DYN-9407] Handle PhoneticRun elements for import-excel node
Reviewers