DYN-9693: Python migration toast notification should close when closing a graph#16599
Merged
zeusongit merged 1 commit intoDynamoDS:masterfrom Oct 17, 2025
Merged
DYN-9693: Python migration toast notification should close when closing a graph#16599zeusongit merged 1 commit intoDynamoDS:masterfrom
zeusongit merged 1 commit intoDynamoDS:masterfrom
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-9693
Contributor
There was a problem hiding this comment.
Pull Request Overview
Fix ensures the CPython migration toast notification is closed when a workspace/graph is closed to prevent it persisting and repositioning unexpectedly on reopen.
- Adds handler OnCurrentWorkspaceCleared to close the toast.
- Subscribes/unsubscribes to new CurrentWorkspaceCleared event.
benglin
approved these changes
Oct 17, 2025
Contributor
benglin
left a comment
benglin
left a comment
There was a problem hiding this comment.
Weeelp, given what we have in ReadyParams I think this a great solution, @zeusongit. LGTM! 🚀
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
When a user opens a graph with CPython3 nodes they see a toast notification, if the user closes the graph without dismissing the toast notification, it stays, and when the graph is reopened the notification jumps to a different location on the screen
Declarations
Check these if you believe they are true
Release Notes
Python migration toast notification should close when closing a graph
Reviewers
(FILL ME IN) Reviewer 1 (If possible, assign the Reviewer for the PR)
(FILL ME IN, optional) Any additional notes to reviewers or testers.
FYIs
(FILL ME IN, Optional) Names of anyone else you wish to be notified of