Skip to content

[DYN-9678] Fix memory leak and prevent process hanging.#16570

Closed
reddyashish wants to merge 5 commits intoDynamoDS:masterfrom
reddyashish:memoryleak
Closed

[DYN-9678] Fix memory leak and prevent process hanging.#16570
reddyashish wants to merge 5 commits intoDynamoDS:masterfrom
reddyashish:memoryleak

Conversation

@reddyashish
Copy link
Collaborator

@reddyashish reddyashish commented Oct 3, 2025

Purpose

https://jira.autodesk.com/browse/DYN-9678

Fixing the memory leak and prevent process hanging. Started noticing this after 3.5 release. Will need more testing in host environments.

Declarations

Check these if you believe they are true

Release Notes

Fix memory leak and prevent process hanging.

Reviewers

@DynamoDS/eidos

{
try
{
Application.Current.Shutdown();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would this be host application in certain cases instead of sandbox?

Copy link
Collaborator Author

@reddyashish reddyashish Oct 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah i need to test this in Revit. Also, Made it a draft to run some tests.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Were you able to test this in Revit?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forgot to bring this up at standup, was seeing another issue on Revit with this change, i am looking into it, think i can fix that. Will update soon.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this now validated with Revit?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes validated with revit. Can merge and would be nice to have Neal test it as well.

@reddyashish reddyashish marked this pull request as draft October 3, 2025 10:41
@reddyashish reddyashish marked this pull request as ready for review October 15, 2025 06:50
@reddyashish reddyashish changed the title Fix memory leak and prevent process hanging. [DYN-9678] Fix memory leak and prevent process hanging. Oct 15, 2025
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@reddyashish
Copy link
Collaborator Author

Closing this in favor of #16606, same changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants