DYN-8974: disable sign in on no network mode#16550
DYN-8974: disable sign in on no network mode#16550zeusongit merged 2 commits intoDynamoDS:masterfrom
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-8974
needs to be added |
There was a problem hiding this comment.
Pull Request Overview
This PR disables the sign-in functionality when Dynamo is running in "no network mode" to provide a better user experience by preventing failed authentication attempts when network connectivity is unavailable. The changes introduce logic to conditionally disable the login menu and provide appropriate user feedback.
- Disables the login menu when
NoNetworkModeis enabled - Updates tooltip text to inform users how to enable sign-in functionality
- Ensures tooltip is visible even when the button is disabled
Reviewed Changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| DynamoView.xaml.cs | Adds logic to disable login menu when no network mode is active |
| ShortcutToolbar.xaml.cs | Sets initial login menu state based on network mode during toolbar load |
| ShortcutToolbar.xaml | Enables tooltips on disabled buttons and implements conditional tooltip content |
| Resources.resx | Adds new tooltip text for offline sign-in state |
| Resources.en-US.resx | Adds English localization for the new offline tooltip |
Files not reviewed (1)
- src/DynamoCoreWpf/Properties/Resources.Designer.cs: Language not supported
fixed! |
Purpose
Disable sign in on no network mode
Declarations
Check these if you believe they are true
Release Notes
Disable sign in on no network mode
Reviewers
@DynamoDS/eidos
@DynamoDS/synapse
FYIs
(FILL ME IN, Optional) Names of anyone else you wish to be notified of