Skip to content

DYN-8972: Disable data collection agreements in NoNetworkMode#16534

Merged
zeusongit merged 6 commits intoDynamoDS:masterfrom
kalunkuo:DYN-8972
Oct 1, 2025
Merged

DYN-8972: Disable data collection agreements in NoNetworkMode#16534
zeusongit merged 6 commits intoDynamoDS:masterfrom
kalunkuo:DYN-8972

Conversation

@kalunkuo
Copy link
Contributor

@kalunkuo kalunkuo commented Sep 29, 2025 •
edited
Loading

Purpose

  • Disable data collection agreements in NoNetworkMode
  • Added a NoNetworkMode check to the UsageReportingManager.CheckIsFirstRun() method
  • Modify HideReportOptions logic to include NoNetworkMode condition

Testing

  • Verified no data collection dialog appears in no-network mode
  • Confirmed normal mode still shows dialog as expected
  • Tested with --NoNetworkMode command line argument

Declarations

Check these if you believe they are true

Release Notes

Ensures no-network mode disable the terms of use (data agreement) dialog at startup

Reviewers

@DynamoDS/eidos @DynamoDS/synapse

@kalunkuo kalunkuo requested review from a team and Copilot September 29, 2025 18:03
Copilot AI reviewed Sep 29, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR disables data collection agreements in no-network mode by adding a check to prevent the usage reporting dialog from appearing when Dynamo is running with network access disabled.

  • Added NoNetworkMode check to prevent data collection dialog in no-network mode
  • Maintains existing behavior for normal mode operation

@github-actions github-actions bot changed the title DYN 8972: Disable data collection agreements in NoNetworkMode DYN-: DYN 8972: Disable data collection agreements in NoNetworkMode Sep 29, 2025
github-actions[bot]
github-actions bot reviewed Sep 29, 2025
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-8972

@kalunkuo kalunkuo changed the title DYN-: DYN 8972: Disable data collection agreements in NoNetworkMode DYN-8972: Disable data collection agreements in NoNetworkMode Sep 29, 2025
@zeusongit
Copy link
Contributor

zeusongit commented Sep 29, 2025 •
edited
Loading

I think NoNetwork mode can be enabled even if it is not the First Run, and we should catch those cases as well. Is this the only place we trigger ShowUsageReportingPrompt() ?

@kalunkuo
Copy link
Contributor Author

kalunkuo commented Sep 29, 2025

I think NoNetwork mode can be enabled even if it is not the First Run, and we should catch those cases as well. Is this the only place we trigger ShowUsageReportingPrompt() ?

Good call @zeusongit ! ShowUsageReportingPrompt() is also triggered here

        public void ToggleIsAnalyticsReportingApproved(object parameter)
        {
            var ownerWindow = parameter as Window;
            if (ownerWindow == null)
            {
                throw new InvalidOperationException(
                    "DynamoView must be supplied for this command");
            }
            ShowUsageReportingPrompt(ownerWindow);
        }

@kalunkuo
Copy link
Contributor Author

kalunkuo commented Sep 29, 2025

I added the MessageBox:
Screenshot 2025-09-29 at 2 55 47 PM

zavub
zavub reviewed Sep 29, 2025
View reviewed changes
src/DynamoCoreWpf/Services/UsageReportingManager.cs Outdated
}

// Skip analytics prompt in no-network mode
if (dynamoViewModel?.Model?.NoNetworkMode == true)
Copy link
Contributor

@zavub zavub Sep 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps we could simply not show the toggle at all in Dynamo view ? Otherwise I assume this message will need to be localized.

Copy link
Contributor Author

@kalunkuo kalunkuo Sep 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea!

Screenshot 2025-09-29 at 4 04 22 PM

@aparajit-pratap
Copy link
Contributor

aparajit-pratap commented Sep 30, 2025

I added the MessageBox: Screenshot 2025-09-29 at 2 55 47 PM

I do not see any code for this message box 😕

@kalunkuo
Copy link
Contributor Author

kalunkuo commented Sep 30, 2025

I added the MessageBox: Screenshot 2025-09-29 at 2 55 47 PM

I do not see any code for this message box 😕

@aparajit-pratap I removed it after seeing @zavub's yesterday. Currently, it is not show the toggle at all in Dynamo view if in NoNetworkMode:

image

@zeusongit zeusongit merged commit 1d8fee1 into DynamoDS:master Oct 1, 2025
25 of 27 checks passed
@aparajit-pratap
Copy link
Contributor

aparajit-pratap commented Oct 1, 2025

I added the MessageBox: Screenshot 2025-09-29 at 2 55 47 PM

I do not see any code for this message box 😕

@aparajit-pratap I removed it after seeing @zavub's yesterday. Currently, it is not show the toggle at all in Dynamo view if in NoNetworkMode:

image

I don't get it, what toggle?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

Copilot code review Copilot Copilot left review comments

@BogdanZavu BogdanZavu BogdanZavu approved these changes

@zeusongit zeusongit zeusongit approved these changes

+1 more reviewer

@zavub zavub zavub left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@kalunkuo @zeusongit @aparajit-pratap @zavub @BogdanZavu