DYN-9196: update to not exclude 8.0#16525
Conversation
github-actions
bot
changed the title
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-9196
| ## DynamoServices.dll is multi-targeted, we sign the binaries for the nuget package separately. | ||
| ..\..\NodeServices\obj\netstandard2.0\DynamoServices.dll | ||
| ..\..\NodeServices\obj\net8.0\DynamoServices.dll | ||
| ..\..\NodeServices\obj\net10.0\DynamoServices.dll No newline at end of file |
There was a problem hiding this comment.
adding the newly generated dll to be signed
zeusongit
left a comment
zeusongit
left a comment
There was a problem hiding this comment.
net10 job passed putting this back in to test
|
@dnenov, can you explain why we added net8 and net10 target frameworks to DynamoServices? Could we not have left it as netstandard? |
I only added net10 as part of this PR, following the logic we had before. We had both net8.0 and netstandard2.0. In essence, we added .NET 10 target and keep .NET 8 / netstandard2.0 for compatibility. There was a separate jira ticket for multitarget support here: |
Here is a screenshot |
|
@QilongTang, my question was why the task was created to multitarget DynamoServices (was there a specific need). I suppose there is no harm in doing this, just wanted to understand. |
I think it was already multi-targeting even before the .NET10 introduction so it was not a new practice? |
Co-authored-by: QilongTang <[email protected]>
4 participants
Purpose
Update to nuget
Declarations
Check these if you believe they are true
Release Notes
Reviewers
@QilongTang
@avidit
FYIs