DYN-9197: Add global.json#16517
Conversation
There was a problem hiding this comment.
Pull Request Overview
This pull request adds a global.json file to standardize the .NET SDK version across the project and updates build configurations and GitHub workflows to use .NET 10.0. The changes streamline the build process by removing redundant inline global.json creation steps from workflows.
Key Changes:
- Addition of a global.json file specifying .NET SDK 10.0.100-preview.7.25380.108
- Update of build.xml to target .NET 10.0 instead of .NET 8.0
- Simplification of GitHub workflows by removing inline global.json creation
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| global.json | New file defining .NET SDK version and project structure |
| src/build.xml | Updated .NET target framework to net10.0 and improved XML formatting |
| .github/workflows/dynamo_bin_diff.yml | Removed inline global.json creation and .NET 9.0.x setup |
| .github/workflows/build_dynamo_core.yml | Removed inline global.json creation and streamlined restore commands |
| .github/workflows/build_dynamo_all.yml | Removed inline global.json creation and improved command formatting |
| .editorconfig | Added YAML indentation configuration |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-9197
|
Dynamo bin diff - |
|
I saw the path error now, do you want to merge now and do a follow up PR? |
I am hoping for this PR to resolve the long path issue. The new image is still baking. If that doesn't solve it, we can look for other ways. |
Co-authored-by: QilongTang <[email protected]>
Purpose
https://learn.microsoft.com/en-us/dotnet/core/tools/global-json
global.json, devs are expected to have .net10 SDK version10.0.100-preview.7.25380.108or above installed on their system.10.0.xwithsetup-dotnetaction10.0.100-preview.7.25380.108installedDeclarations
Check these if you believe they are true
Release Notes
N/A
Reviewers
(FILL ME IN) Reviewer 1 (If possible, assign the Reviewer for the PR)
(FILL ME IN, optional) Any additional notes to reviewers or testers.
FYIs
(FILL ME IN, Optional) Names of anyone else you wish to be notified of