DYN-9244 Moving Away ProgramData Fix#16492
Conversation
f you previously used Dynamo 4.0.0 and now with the previous fix try to use it, you will see that is loading packages from C:\ProgramData\Dynamo\Dynamo Core\4.0\packages. The problem is that DynamoSettings.xml in C:\Users\tellro\AppData\Roaming\Dynamo\Dynamo Core\4.0 already contains the entry for ProgramData then you need to delete the Dynamo cache in order to verify my fix. With this fix doesn't matter if the Dynamo cache was deleted or not now it won't be loading any package from the ProgramData path.
RobertGlobant20
requested review from
QilongTang,
Copilot,
reddyashish and
zeusongit
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-9244
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue where Dynamo continues to load packages from the ProgramData directory even after a previous fix was intended to prevent this behavior. The problem occurs when users upgrade from older Dynamo versions that have ProgramData entries cached in their DynamoSettings.xml file.
Key Changes:
- Enhanced package directory filtering to explicitly exclude ProgramData paths
- Added programmatic detection of the ProgramData folder path using Environment.GetFolderPath
|
GIF showing the expected behavior of not loading package even if we have the entry in DynamoSettings.xml |
|
@RobertGlobant20 Wanna check the Copilot PR review comments? |
Implementing fixes suggested by GitHub Copilot.
QilongTang
left a comment
QilongTang
left a comment
There was a problem hiding this comment.
One comment then LGTM
|
@RobertGlobant20 Please merge master into this branch |
Purpose
If you previously used Dynamo 4.0.0 and now with the previous fix try to use it, you will see that is loading packages from C:\ProgramData\Dynamo\Dynamo Core\4.0\packages. The problem is that DynamoSettings.xml in C:\Users\tellro\AppData\Roaming\Dynamo\Dynamo Core\4.0 already contains the entry for ProgramData then you need to delete the Dynamo cache in order to verify my fix.
With this fix doesn't matter if the Dynamo cache was deleted or not, now it won't be loading any package from the ProgramData path.
Declarations
Check these if you believe they are true
Release Notes
Fixing problem that is loading packages from ProgramData due that a previous version of Dynamo that doesn't have my fix was used
Reviewers
@reddyashish @zeusongit @QilongTang
FYIs