DYN-9089: Open dropdown on first text input hit#16379
Merged
johnpierson merged 1 commit intoDynamoDS:masterfrom Jul 15, 2025
Merged
DYN-9089: Open dropdown on first text input hit#16379johnpierson merged 1 commit intoDynamoDS:masterfrom
johnpierson merged 1 commit intoDynamoDS:masterfrom
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-9089
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enables the autocomplete dropdown to open on the very first character typed into the search box rather than only when results are populated.
- Added a
PreviewTextInputhandler in the view to open the dropdown and seed the first character. - Wired that handler in XAML on the window.
- Removed the previous always-open logic from
PopulateAutoCompletein the view model.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/NodeAutoCompleteViewExtension/Views/NodeAutoCompleteBarView.xaml.cs | Added NodeAutoCompleteBarView_PreviewTextInput to open the dropdown on first text input. |
| src/NodeAutoCompleteViewExtension/Views/NodeAutoCompleteBarView.xaml | Hooked up PreviewTextInput event on the window. |
| src/NodeAutoCompleteViewExtension/ViewModels/NodeAutoCompleteBarViewModel.cs | Removed unconditional IsDropDownOpen = true in PopulateAutoComplete. |
Comments suppressed due to low confidence (1)
src/NodeAutoCompleteViewExtension/Views/NodeAutoCompleteBarView.xaml.cs:344
- Add unit or automated UI tests for this new
PreviewTextInputhandler to verify that the dropdown opens correctly on the first character input and that subsequent characters append as expected.
if(ViewModel != null && ViewModel.HasUnfilteredResults && !ViewModel.IsDropDownOpen)
johnpierson
approved these changes
Jul 15, 2025
Member
johnpierson
left a comment
johnpierson
left a comment
There was a problem hiding this comment.
this works awesome and exactly as I would expect as a Dynamo user.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Open dropdown on first text input hit
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Open dropdown on first text input hit
Reviewers
@DynamoDS/synapse
FYIs
(FILL ME IN, Optional) Names of anyone else you wish to be notified of