DYN-8778 - alert user to login#16367
Merged
johnpierson merged 7 commits intoDynamoDS:masterfrom Jul 11, 2025
Merged
Conversation
johnpierson
changed the title
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-8778
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR replaces hardcoded “no suggestions” placeholders with dynamic ML-based titles and messages, introduces a user authentication flag for controlling placeholder visibility, and cleans up obsolete resources and minor documentation whitespace.
- Swap out
BoxPlaceholder/NoItemsPlaceholderforTitlePlaceholder/MessagePlaceholderwith bindings and aDataTriggerforDisplayAutocompleteMLStaticPage - Add
IsUserAuthenticatedproperty in the ViewModel to gate ML content based on login state - Remove old resource entries and update core resource strings for consistency
- Clean up trailing blanks in the Node Autocomplete documentation HTML
Reviewed Changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/NodeAutoCompleteViewExtension/Views/NodeAutoCompleteBarView.xaml | Update placeholders to bind to ML properties and add DataTrigger |
| src/NodeAutoCompleteViewExtension/ViewModels/NodeAutoCompleteBarViewModel.cs | Add IsUserAuthenticated and initial RaisePropertyChanged call |
| src/DynamoCoreWpf/PublicAPI.Unshipped.txt | Remove obsolete AutocompleteNoSuggestions and AutocompletePlaceholder getters |
| src/DynamoCoreWpf/Properties/Resources.resx & Resources.en-US.resx | Remove old placeholder entries |
| src/DynamoCore/Properties/Resources.resx & Resources.en-US.resx | Change "No recommendations" title/message to new suggestion text |
| src/DynamoCoreWpf/Controls/Docs/en-US/NodeAutocompleteDocumentation.html | Whitespace cleanup only |
Files not reviewed (1)
- src/DynamoCoreWpf/Properties/Resources.Designer.cs: Language not supported
Comments suppressed due to low confidence (4)
src/NodeAutoCompleteViewExtension/ViewModels/NodeAutoCompleteBarViewModel.cs:408
- There are no unit tests covering the new
IsUserAuthenticatedlogic. Add tests to verify both authenticated and unauthenticated cases.
internal bool IsUserAuthenticated
src/DynamoCoreWpf/Controls/Docs/en-US/NodeAutocompleteDocumentation.html:1
- The documentation hasn't been updated to describe the new ML static page behavior or login alert. Consider adding a section explaining
DisplayAutocompleteMLStaticPageand the new title/message placeholders.
<!--
src/DynamoCoreWpf/PublicAPI.Unshipped.txt:4549
- Removing these public resource getters is a breaking change. Ensure the API Changes document is updated to note this removal under Semantic Versioning guidelines.
static Dynamo.Wpf.Properties.Resources.AddStyleButton.get -> string
src/NodeAutoCompleteViewExtension/Views/NodeAutoCompleteBarView.xaml:10
- The
propertiesXML namespace is added but never used in this XAML. Consider removing it to reduce clutter.
xmlns:properties="clr-namespace:Dynamo.Properties;assembly=DynamoCore"
src/NodeAutoCompleteViewExtension/ViewModels/NodeAutoCompleteBarViewModel.cs
Outdated
Show resolved
Hide resolved
* fix cluster unlogged * undo html changes
chubakueno
approved these changes
Jul 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This PR replaces hardcoded “no suggestions” placeholders with dynamic ML-based titles and messages, introduces a user authentication flag for controlling placeholder visibility, and cleans up obsolete resources and minor documentation whitespace.
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
(FILL ME IN) Brief description of the fix / enhancement. Use N/A to indicate that the changes in this pull request do not apply to Release Notes. Mandatory section
Reviewers
@DynamoDS/synapse
FYIs
@Jingyi-Wen