DYN-9093 Update default backup interval to 5 minutes#16358
Merged
zeusongit merged 4 commits intoDynamoDS:masterfrom Jul 9, 2025
Merged
DYN-9093 Update default backup interval to 5 minutes#16358zeusongit merged 4 commits intoDynamoDS:masterfrom
zeusongit merged 4 commits intoDynamoDS:masterfrom
Conversation
Changed the default backup interval from 1 minute (60000ms) to 5 minutes (300000ms). Added logic to migrate existing settings using the old interval to the new default value.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-9093
Contributor
There was a problem hiding this comment.
Pull Request Overview
Updates the default backup interval from 1 minute to 5 minutes and adds logic to migrate any existing setting still using the old interval.
- Changed
DefaultBackupIntervalconstant from 60000ms to 300000ms. - Added migration code to reset saved intervals of 60000ms to the new default.
Comments suppressed due to low confidence (2)
src/DynamoCore/Configuration/PreferenceSettings.cs:1114
- [nitpick] The variable name
savedBackUpIntervaluses inconsistent casing for "Up"; consider renaming tosavedBackupIntervalto follow normal camelCase conventions.
var savedBackUpInterval = settings?.BackupInterval;
src/DynamoCore/Configuration/PreferenceSettings.cs:1113
- There’s no accompanying unit test to verify that a saved interval of 60000ms is correctly migrated to the new default. Consider adding a test for this migration scenario.
// If the backup interval is set to 60000ms (1 minute) - old backup interval, reset it to the new default value.
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
aparajit-pratap
approved these changes
Jul 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Changed the default backup interval from 1 minute (60000ms) to 5 minutes (300000ms). Added logic to migrate existing settings using the old interval to the new default value.
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Changed the default backup interval from 1 minute (60000ms) to 5 minutes (300000ms). Added logic to migrate existing settings using the old interval to the new default value.
Reviewers
(FILL ME IN) Reviewer 1 (If possible, assign the Reviewer for the PR)
(FILL ME IN, optional) Any additional notes to reviewers or testers.
FYIs
(FILL ME IN, Optional) Names of anyone else you wish to be notified of