DYN-9028: force recalculate formula fields#16352
Merged
zeusongit merged 2 commits intoDynamoDS:masterfrom Jul 9, 2025
Merged
Conversation
- requests full calculation when opening the excel file after writing it with Dynamo OpenXML
stylesheet.NumberingFormats can be null, this prevents from null exception to happen
github-actions
bot
changed the title
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-9028
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR ensures that Excel formula fields are recalculated when the file is opened and adds a null‐safe check for numbering formats when formatting cell values.
- Forces full recalculation of formulas on load
- Adds null check around
stylesheet.NumberingFormatsto avoid NRE - Returns unformatted value string if no numbering format is found
Reviewed Changes
Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| OpenXmlHelper.cs (Write method) | Appends CalculationProperties and sets FullCalculationOnLoad = true to force formula recalculation |
| OpenXmlHelper.cs (GetCellValue block) | Uses null‐safe access (?.ElementAt) on NumberingFormats and early returns unformatted string when missing |
zeusongit
approved these changes
Jul 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This PR follows the issue discussed here: https://jira.autodesk.com/browse/DYN-9028 - Formulas breaking (not recomputing) after exporting new data using OpenXML node to an existing Excel with Formula
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
stylesheet.NumberingFormatsisnullReviewers
@jasonstratton
@zeusongit
@achintyabhat
FYIs
@reddyashish