Skip to content

DYN-9109: make autocomplete flyout follow node and dynamo window.#16341

Merged
johnpierson merged 2 commits intoDynamoDS:masterfrom
chubakueno:feature/DYN-9109
Jul 10, 2025
Merged

DYN-9109: make autocomplete flyout follow node and dynamo window.#16341
johnpierson merged 2 commits intoDynamoDS:masterfrom
chubakueno:feature/DYN-9109

Conversation

@chubakueno
Copy link
Contributor

@chubakueno chubakueno commented Jul 3, 2025 •
edited
Loading

Purpose

Make autocomplete flyout follow node and dynamo window.

2025-07-09.12-45-59.mp4
2025-07-09.13-38-40.mp4

Declarations

Check these if you believe they are true

  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB
  • This PR introduces new feature code involve network connecting and is tested with no-network mode.

Release Notes

Make autocomplete flyout follow node and dynamo window.

Reviewers

@johnpierson
@BogdanZavu

FYIs

(FILL ME IN, Optional) Names of anyone else you wish to be notified of

github-actions[bot]
github-actions bot reviewed Jul 3, 2025
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-9109

@BogdanZavu
Copy link
Contributor

BogdanZavu commented Jul 8, 2025

I'm not sure about the snapping behavior when the node is moved. it might be seen as a bug.
Maybe just apply the last move vector from the node to the existing flyout position ?

@johnpierson
Copy link
Member

johnpierson commented Jul 8, 2025

I agree with @BogdanZavu - Lets just move the DNA flyout along with the node and not snap it back in place @chubakueno .

@chubakueno
Copy link
Contributor Author

chubakueno commented Jul 8, 2025

Right now its done the most intuitive way - keeping a displacement between the node and the flyout would be trickier. Also, it would make possible to push the flyout outside the screen.

Which could again be mitigated by clipping the absolute coordinates of the window, but i think this way is OK.

@chubakueno chubakueno mentioned this pull request Jul 9, 2025
Merged
8 tasks
johnpierson
johnpierson approved these changes Jul 9, 2025
View reviewed changes
Copy link
Member

@johnpierson johnpierson left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this lgtm! I like how this works.
20250709-DNASnap

@johnpierson johnpierson merged commit e7d1839 into DynamoDS:master Jul 10, 2025
29 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@johnpierson johnpierson johnpierson approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@chubakueno @BogdanZavu @johnpierson